Conversation
Add a complete kernelgen backend that generates NKI kernels via MLIR, as an alternative to the existing HLO backend. This includes: - Kernelgen backend with MLIR encapsulated behind a builder API - Op implementations for kernelgen (_kernelgen_impls.py) - Inplace update (dynamic_update_slice) support - Unified IR interface for HLO and kernelgen backends - Custom op interface via nki_op.nki_custom_op - Compilation delegation to nkipy_kernelgen.compile - Comprehensive unit and numerical tests
aws-zhehongb
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComputationIRabstraction, including uniform input/output name resolution and compilation delegation_kernelgen_impls.py,_register_kernelgen.py) with support for inplace updates (dynamic_update_slice) and custom ops vianki_op.nki_custom_optest_kernelgen_backend.py), op tests (test_kernelgen_ops.py), and numerical tests (test_kernelgen_numerical.py)Test plan
uv run pytest tests/unit/test_kernelgen_backend.py -v -n autouv run pytest tests/test_kernelgen_ops.py -v -n autouv run pytest tests/test_kernelgen_numerical.py -v -n autouv run pytest tests/ -n auto(full suite)